Fix bottom panel dock layout popup position - #113339
Merged
Merged
Conversation
kitbdev
approved these changes
Dec 13, 2025
kitbdev
left a comment
kitbdev
left a comment
Contributor
There was a problem hiding this comment.
Tested, fixes the issue.
KoBeWi
reviewed
Dec 13, 2025
Update EditorDockManager::_dock_container_popup to consistently use tab bar position to determine popup position, rather than combining tab bar and container positions. This handles cases where the tabs are on the bottom of the container, like for the bottom panel.
aaronp64
force-pushed
the
bottom_dock_popup
branch
from
December 14, 2025 15:19
5df0e9f to
a7e227b
Compare
KoBeWi
approved these changes
Dec 14, 2025
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Fix bottom panel dock layout popup position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
EditorDockManager::_dock_container_popupto consistently use tab bar position to determine popup position, rather than combining tab bar and container positions. This handles cases where the tabs are on the bottom of the container, like for the bottom panel.Fixes #113333