Implement EditorTextureImportPlugin to extend texture importer#105342
Implement EditorTextureImportPlugin to extend texture importer#105342beicause wants to merge 2 commits intogodotengine:masterfrom
Conversation
cf0fbe8 to
7a800a9
Compare
7a800a9 to
bae898a
Compare
bae898a to
e2a90fa
Compare
e2a90fa to
a4ab645
Compare
|
The naming of "add_import_option_advanced" is misleading. It made me think that it adds an option to advanced import. However, for compatibility and consistency, I follow this naming as it's also used in EditorSceneFormatImporter and EditorScenePostImportPlugin. |
|
Renamed This PR has limitations. If you want to import custom resource that contains ctex, it is still only possible to use Let me know if this design is reasonable, or if there is a better way to extend texture importer. |
|
Sorry I missed this at the last asset import meeting. At a first glance, it looks really good. There has been a lot to get through and we didn't get everything done in time for 4.5 I'm a little worried that it's a bit of a complicated new API and there is a lot of risk in merging this too quickly such that we can't improve it. Once 4.5 beta ships, we need to maintain API stability. One option is to ship this now as an experimental API, but it's a little rushed given that others haven't given it a review yet, so I'm leaning on getting this in early in the 4.6 dev cycle so we have time to play with this and fix things. |
|
I will reconsider it. Ideally, it should also support TextureLayered (texture2darray, cubemap, texture3d). |
Partially implements godotengine/godot-proposals#1943
This PR intends to address the situation that many proposals need options to customize texture importer:
Related PRs:
EditorTextureImportPlugincan be used to extendResourceImporterTextureand modify the process of importingCompressedTexture2D, allowing to load custom file format, add importer options, and change the image when processing.The design mainly refers to the
EditorScenePostImportPlugin.Example: