Capitalize text in SpinBox and EditorSpinSlider to parse with Expression#105330
Closed
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Closed
Capitalize text in SpinBox and EditorSpinSlider to parse with Expression#105330aaronfranke wants to merge 1 commit intogodotengine:masterfrom
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
|
What about methods such as randf()? |
Member
Author
|
@MewPurPur Dang, you're right. I guess we could specifically search for the constants and capitalize them, but that seems like a really specific hack. Honestly, I would prefer to just re-open PR #100395. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #100395. For example, this allows typing
tau/4instead ofTAU/4in the editor. If we also re-enable infinity, this would also fix the problem where users need to typeINFbut it's displayed asinf, and typinginfdoesn't work.