Skip to content

Fix cannot input Chinese after restarting the input method on X11#103749

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Rindbee:fix-cannot-input-after-restarting-the-input-method-on-x11
Nov 19, 2025
Merged

Fix cannot input Chinese after restarting the input method on X11#103749
Repiteo merged 1 commit into
godotengine:masterfrom
Rindbee:fix-cannot-input-after-restarting-the-input-method-on-x11

Conversation

@Rindbee

@Rindbee Rindbee commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Register a callback via XRegisterIMInstantiateCallback() to detect whether the input method is available again.

Fix #103748.

002.mp4

@Rindbee Rindbee requested a review from a team as a code owner March 7, 2025 06:21
@Rindbee Rindbee marked this pull request as draft March 7, 2025 06:52
@Chaosus Chaosus added this to the 4.x milestone Mar 7, 2025
@Rindbee Rindbee force-pushed the fix-cannot-input-after-restarting-the-input-method-on-x11 branch from a085d92 to 0c681db Compare March 7, 2025 09:40
@Rindbee Rindbee marked this pull request as ready for review March 7, 2025 10:06
@AThousandShips AThousandShips modified the milestones: 4.x, 4.5 Mar 7, 2025
@Rindbee Rindbee force-pushed the fix-cannot-input-after-restarting-the-input-method-on-x11 branch from 0c681db to 9ffe872 Compare March 7, 2025 10:11

@timothyqiu timothyqiu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the code, but after applying this patch, I can indeed continue to input as normal after restarting the IME (fcitx5).

Comment thread platform/linuxbsd/x11/display_server_x11.cpp Outdated
@Rindbee Rindbee force-pushed the fix-cannot-input-after-restarting-the-input-method-on-x11 branch from 9ffe872 to 90c9c8a Compare March 7, 2025 12:26
@akien-mga akien-mga requested a review from bruvzg March 7, 2025 12:27

@bruvzg bruvzg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine.

Comment thread platform/linuxbsd/x11/display_server_x11.cpp Outdated
Register a callback via `XRegisterIMInstantiateCallback()` to detect
whether the input method is available again.
@Rindbee Rindbee force-pushed the fix-cannot-input-after-restarting-the-input-method-on-x11 branch from 90c9c8a to 456261c Compare March 10, 2025 09:18
@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 8, 2025
@Repiteo Repiteo merged commit 2135cb1 into godotengine:master Nov 19, 2025
@Repiteo

Repiteo commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Thanks!

@Rindbee Rindbee deleted the fix-cannot-input-after-restarting-the-input-method-on-x11 branch November 20, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restarting the input method while the engine is running will result in an inability to input Chinese

7 participants