Skip to content

Allow using any-case constants in Expression #100395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronfranke wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −12
Open

Allow using any-case constants in Expression #100395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions core/math/expression.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,36 +441,37 @@ Error Expression::_get_token(Token &r_token) {

str_ofs--; //go back one

if (id == "in") {
const String lowercase_id = id.to_lower();
if (lowercase_id == "in") {
r_token.type = TK_OP_IN;
} else if (id == "null") {
} else if (lowercase_id == "null") {
r_token.type = TK_CONSTANT;
r_token.value = Variant();
} else if (id == "true") {
} else if (lowercase_id == "true") {
r_token.type = TK_CONSTANT;
r_token.value = true;
} else if (id == "false") {
} else if (lowercase_id == "false") {
r_token.type = TK_CONSTANT;
r_token.value = false;
} else if (id == "PI") {
} else if (lowercase_id == "pi") {
r_token.type = TK_CONSTANT;
r_token.value = Math::PI;
} else if (id == "TAU") {
} else if (lowercase_id == "tau") {
r_token.type = TK_CONSTANT;
r_token.value = Math::TAU;
} else if (id == "INF") {
} else if (lowercase_id == "inf") {
r_token.type = TK_CONSTANT;
r_token.value = Math::INF;
} else if (id == "NAN") {
} else if (lowercase_id == "nan") {
r_token.type = TK_CONSTANT;
r_token.value = Math::NaN;
} else if (id == "not") {
} else if (lowercase_id == "not") {
r_token.type = TK_OP_NOT;
} else if (id == "or") {
} else if (lowercase_id == "or") {
r_token.type = TK_OP_OR;
} else if (id == "and") {
} else if (lowercase_id == "and") {
r_token.type = TK_OP_AND;
} else if (id == "self") {
} else if (lowercase_id == "self") {
r_token.type = TK_SELF;
} else {
{
Expand Down
Loading