-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Clarify GDExtension GDRegister types in C++ Tutorial #11578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
34f3197 to
bb5d462
Compare
|
Note that this is also explained elsewhere: Which is a page linked from the godot-cpp docs: I'm guessing one reason for the confusion could be that the info is sort of new and hasn't been cherry-picked to |
|
@Ivorforce Great catch, thanks for pointing those out. There's still a case to be made for this brief warning, or perhaps just adding one sentence: "More info on Object Registration methods can be found [link]" It definitely appears you're right, those PRs hadn't even been created when Issue godotengine/godot#107195 was posted, but with that I'm certainly satisfied closing the original issue, and adjusting or closing this PR. |
bb5d462 to
c089ea6
Compare
c089ea6 to
ec56141
Compare
ec56141 to
7b4ca19
Compare
|
Thanks for the feedback @AThousandShips @Ivorforce - just changed to Ivor's suggestion of just using GDRegister_Class, with the simpler note. Let me know if any formatting or wording still needs to be adjusted. |
Ivorforce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
paddy-exe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻
|
Thank you, and thanks for the reviews everyone! |
Adds a clarifying note about the different types of GDRegister in the GDExtension C++ Tutorial.
Based on Issue: godotengine/godot#107195