Skip to content

Conversation

@ColinSORourke
Copy link
Contributor

Adds a clarifying note about the different types of GDRegister in the GDExtension C++ Tutorial.

Based on Issue: godotengine/godot#107195

@ColinSORourke ColinSORourke force-pushed the GDExt_Registers branch 2 times, most recently from 34f3197 to bb5d462 Compare January 2, 2026 10:08
@Ivorforce
Copy link
Member

Ivorforce commented Jan 6, 2026

Note that this is also explained elsewhere:
https://docs.godotengine.org/en/latest/engine_details/architecture/object_class.html#registering-object-classes

Which is a page linked from the godot-cpp docs:
https://docs.godotengine.org/en/latest/tutorials/scripting/cpp/core_types.html

I'm guessing one reason for the confusion could be that the info is sort of new and hasn't been cherry-picked to stable yet? (#11447 and #11438)

@ColinSORourke
Copy link
Contributor Author

ColinSORourke commented Jan 7, 2026

@Ivorforce Great catch, thanks for pointing those out. There's still a case to be made for this brief warning, or perhaps just adding one sentence: "More info on Object Registration methods can be found [link]"

It definitely appears you're right, those PRs hadn't even been created when Issue godotengine/godot#107195 was posted, but with that I'm certainly satisfied closing the original issue, and adjusting or closing this PR.

@ColinSORourke
Copy link
Contributor Author

ColinSORourke commented Jan 8, 2026

Thanks for the feedback @AThousandShips @Ivorforce - just changed to Ivor's suggestion of just using GDRegister_Class, with the simpler note. Let me know if any formatting or wording still needs to be adjusted.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ivorforce Ivorforce added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension labels Jan 9, 2026
@Ivorforce Ivorforce requested review from a team and paddy-exe January 9, 2026 00:59
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@mhilbrunner mhilbrunner merged commit 5ab0a69 into godotengine:master Jan 10, 2026
1 check passed
@mhilbrunner
Copy link
Member

Thank you, and thanks for the reviews everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.5 enhancement topic:gdextension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants