-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Move C++ container type information from C++ usage guidelines to Core types #10988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Move C++ container type information from C++ usage guidelines to Core types #10988
Conversation
23dcc32
to
26949d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I also added a link to the table in faq.rst
a few commits ago; that one should be adjusted to point here instead too.
References: | ||
~~~~~~~~~~~ | ||
References | ||
~~~~~~~~~~ | ||
|
||
- `core/math <https://github.com/godotengine/godot/tree/master/core/math>`__ | ||
|
||
NodePath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this one belongs in the table?
It's not a typical 'container' per se, but it is somewhat similar to std::filesystem::path
maybe.
Either way it feels a bit weird to have some types up there and some other types down here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed References headings to simplify the page a bit, but I kept the text intact.
I could perhaps merge types like Face3 in the table, but I feel they're a bit too specific. We should also cover typedefs like Point2 and Size2, but this is likely best done in a future PR.
cf78f69
to
23f8f5d
Compare
… types - List recommended types at the top. - Link references directly in the table. - Remove References headings in the rest of the page. - Update Core types for Godot 4.5. - Remove OAHashMap as it's no longer present in 4.5.
23f8f5d
to
a7eabf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot the link i mentioned above :)
Uh oh!
There was an error while loading. Please reload this page.