Move C++ container type information from C++ usage guidelines to Core types #10988
+108
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
area:contributing
Calinou
force-pushed
the
cpp-usage-guidelines-link-to-core-types
branch
from
23dcc32 to
26949d5
Compare
Ivorforce
reviewed
Jun 3, 2025
| References: | ||
| ~~~~~~~~~~~ | ||
| References | ||
| ~~~~~~~~~~ | ||
|
|
||
| - `core/math <https://github.com/godotengine/godot/tree/master/core/math>`__ | ||
|
|
||
| NodePath |
There was a problem hiding this comment.
Perhaps this one belongs in the table?
It's not a typical 'container' per se, but it is somewhat similar to std::filesystem::path maybe.
Either way it feels a bit weird to have some types up there and some other types down here.
There was a problem hiding this comment.
I've removed References headings to simplify the page a bit, but I kept the text intact.
I could perhaps merge types like Face3 in the table, but I feel they're a bit too specific. We should also cover typedefs like Point2 and Size2, but this is likely best done in a future PR.
Calinou
force-pushed
the
cpp-usage-guidelines-link-to-core-types
branch
3 times, most recently
from
cf78f69 to
23f8f5d
Compare
… types - List recommended types at the top. - Link references directly in the table. - Remove References headings in the rest of the page. - Update Core types for Godot 4.5. - Remove OAHashMap as it's no longer present in 4.5.
Calinou
force-pushed
the
cpp-usage-guidelines-link-to-core-types
branch
from
23f8f5d to
a7eabf7
Compare
Ivorforce
reviewed
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.