Skip to content

Update WebSocket documentation for Godot 4 #10986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 3, 2025

There's an issue with the minimal client example where it will return garbage data when connected to the minimal server example (it changes on every client start):

Connecting to ws://localhost:9080...
  ERROR: Unicode parsing error, some characters were replaced with � (U+FFFD): Invalid UTF-8 continuation byte (e9 ... 33 ...)
< Got data from server: �]O
> Sending test packet.

This does not occur if you connect to wss://echo.websocket.org. I tested this on all stable versions between 4.0.stable and 4.4.1.stable, and the outcome was the same in each version.

Edit: Fixed the above issue thanks to @Faless.

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:network cherrypick:4.4 bug labels Jun 3, 2025
@TranquilMarmot
Copy link
Contributor

Awesome, thanks for salvaging! 🫶

Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Hugo Locurcio <[email protected]>
Co-authored-by: Fabio Alessandrelli <[email protected]>
@Calinou Calinou force-pushed the update-websockets branch from 67bfe9a to 3f0f9ed Compare June 6, 2025 19:59
@mhilbrunner mhilbrunner merged commit 3939af4 into godotengine:master Jun 8, 2025
1 check passed
@mhilbrunner
Copy link
Member

Thanks, all of you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.4 enhancement topic:network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Minimal server example outdated on the Networking/WebSocket page.
3 participants