Clarify the global registration of named_classes #10679
Merged
skyace65 merged 3 commits intoFeb 15, 2025
Merged
Conversation
tetrapod00
added
enhancement
topic:gdscript
area:manual
tetrapod00
requested changes
Feb 12, 2025
Commit PR sugestion Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
tetrapod00
approved these changes
Feb 13, 2025
dalexeev
reviewed
Feb 15, 2025
tetrapod00
reviewed
Feb 15, 2025
skyace65
approved these changes
Feb 15, 2025
Member
|
Thanks! And congrats on your first merged PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is my first constribution to the great Godot's documentation, I hope it will be useful.
While reading the doc about gdscript classes, I found the usage of the keyword
class_nameconfusing. Notably, the fact that a named class becomes available globally does not seem intuitive to me, as it's not clearly stated.Seing that gdscript draws some inspiration from Python, as a newcomer it seems reasonable to think that any class must be imported before being used, and that was my first assumption.
Here is a clarification suggestion for the documentation. Feel free to tell me if you think it is a useful addition.