Skip to content

Fix: Add STATUS to CMake message commands missing them #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Fix: Add STATUS to CMake message commands missing them #1786

merged 2 commits into from
Jun 10, 2025

Conversation

marcmarmir
Copy link

Set message mode to STATUS for those missing a mode, to avoid direction to stderr

@marcmarmir marcmarmir requested a review from a team as a code owner June 5, 2025 00:03
@marcmarmir
Copy link
Author

This stops build tools like colcon from interpreting+reporting this output as errors

@enetheru
Copy link
Collaborator

enetheru commented Jun 5, 2025

fair: the documentation for message sasys this for default: (none) or NOTICE - Important message printed to stderr to attract user's attention.

STATUS is appropriate for these.

@dsnopek dsnopek added bug This has been identified as a bug cmake topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.4 labels Jun 9, 2025
@dsnopek dsnopek added this to the 4.x milestone Jun 9, 2025
dsnopek
dsnopek approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 86e32ce into godotengine:master Jun 10, 2025
11 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 24, 2025

Cherry-picked for 4.4 in PR #1805

@marcmarmir marcmarmir deleted the CMake-message-improvement branch June 24, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug cmake topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@marcmarmir @enetheru @dsnopek