Extend version validator to check status#160
Open
Repiteo wants to merge 1 commit intogodotengine:mainfrom
Open
Extend version validator to check status#160Repiteo wants to merge 1 commit intogodotengine:mainfrom
Repiteo wants to merge 1 commit intogodotengine:mainfrom
Conversation
Member
|
This should work in usual/official build cases, but I sometimes make test builds which may not fit the pattern, e.g. the I think we may want to add some interactivity here and flag if there's a status mismatch and give the option to abort or continue anyway. |
f6ea1dc to
247607d
Compare
Contributor
Author
|
Made it prompt on mismatch, as well as moving the validation steps higher up so a user wouldn't have to wait as long for a potential extra input after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will prevent future issues where the status passed doesn't match the status in
version.py