Skip to content

Extend version validator to check status#160

Open
Repiteo wants to merge 1 commit intogodotengine:mainfrom
Repiteo:version-check-expanded
Open

Extend version validator to check status#160
Repiteo wants to merge 1 commit intogodotengine:mainfrom
Repiteo:version-check-expanded

Conversation

@Repiteo
Copy link
Copy Markdown
Contributor

@Repiteo Repiteo commented Apr 24, 2026

Will prevent future issues where the status passed doesn't match the status in version.py

@akien-mga
Copy link
Copy Markdown
Member

This should work in usual/official build cases, but I sometimes make test builds which may not fit the pattern, e.g. the 4.7.dotnet[1-3] builds we've made while status was still dev. Or sometimes things like 4.7.beta1+pr1234 when trying to get some testing for a given PR before merging it.

I think we may want to add some interactivity here and flag if there's a status mismatch and give the option to abort or continue anyway.

@Repiteo Repiteo force-pushed the version-check-expanded branch from f6ea1dc to 247607d Compare April 25, 2026 16:02
@Repiteo
Copy link
Copy Markdown
Contributor Author

Repiteo commented Apr 25, 2026

Made it prompt on mismatch, as well as moving the validation steps higher up so a user wouldn't have to wait as long for a potential extra input after sh clean.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants