Add option to install rootfs from local file - #53
Merged
syntaxerror247 merged 1 commit intoJul 8, 2026
Conversation
dsnopek
reviewed
Jul 4, 2026
Comment on lines
-290
to
-292
| if (hasAsset) { | ||
| outputHandler(OUTPUT_INFO, "> Extracting rootfs from assets...") | ||
| TarXzExtractor.extractAssetTarXz(context, ROOTFS_ASSET_PATH, rootfs) |
Collaborator
There was a problem hiding this comment.
I'd really like to be able to keep the ability to get this from the APK's assets. I use this when working on the rootfs itself, and it makes it very easy to quickly test changes.
Could we keep this in the else branch if the localUri is null?
syntaxerror247
force-pushed
the
local-rootfs-install
branch
from
July 5, 2026 09:25
6358ec7 to
8a924ea
Compare
syntaxerror247
force-pushed
the
local-rootfs-install
branch
from
July 5, 2026 09:30
8a924ea to
bc4aa65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.