Skip to content

Use ::class_name() instead of string literal #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

Use ::class_name() instead of string literal #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2be90
I suggest moving this `&str`
greenfox1505 Feb 28, 2025
aa15ffc
converts to `...class_name().to_string_name()`
greenfox1505 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/recipes/engine-singleton.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ unsafe impl ExtensionLibrary for MyExtension {
// The `&str` identifies your singleton and can be
// used later to access it.
Engine::singleton().register_singleton(
"MyEngineSingleton",
&MyEngineSingleton::class_name().to_string_name(),
&MyEngineSingleton::new_alloc(),
);
}
Expand All @@ -85,7 +85,7 @@ unsafe impl ExtensionLibrary for MyExtension {
// Let's keep a variable of our Engine singleton instance,
// and MyEngineSingleton name.
let mut engine = Engine::singleton();
let singleton_name = "MyEngineSingleton";
let singleton_name = &MyEngineSingleton::class_name().to_string_name();

// Here, we manually retrieve our singleton(s) that we've registered,
// so we can unregister them and free them from memory - unregistering
Expand Down
Loading