Add windows_backend_description() with VM and Hello detection (v0.2.7)#202
Merged
Conversation
Returns one of three labels based on cached one-time detection: - Non-VM + Hello/PIN: TPM 2.0 ECDH P-256 ECIES, Windows Hello gate - Non-VM + no Hello: TPM 2.0 ECDH P-256 ECIES, password gate - VM environment: ECIES P-256, Windows Data Protection API (user-bound) VM and Hello checks run once per process via OnceLock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
hardware_enclave::diagnostics::windows_backend_description() -> &'static strfor use by consuming apps (gocode-dev) in status/doctor output.Returns one of three labels based on cached, one-time-per-process detection:
✓ Windows TPM 2.0 ECDH P-256 ECIES, Windows Hello gate✓ Windows TPM 2.0 ECDH P-256 ECIES, password gate✓ Windows ECIES P-256, Windows Data Protection API (user-bound)VM detection uses the existing
collect_vm_diagnostics().vm_detectedfield. Hello detection uses the existinghello_gate::is_available(). Both are cached viaOnceLockso they run exactly once per process.Test plan