Drop all legacy enclaveapp-* workspace members (v0.2.6)#201
Merged
Conversation
All consuming apps now use hardware-enclave directly:
- sshenc force-software: uses hardware-enclave MockSigner (PR #250)
- sshenc-tpm-bridge: uses hardware_enclave::bridge_server::BridgeServer
- sshenc fuzz: uses hardware_enclave::bridge_server::{BridgeResponse, read_line_bounded}
- gocode-dev: already on hardware-enclave since v0.1.6
Deleted: enclaveapp-core, enclaveapp-bridge, enclaveapp-windows,
enclaveapp-windows-webauthn, enclaveapp-tpm-bridge,
enclaveapp-test-software, enclaveapp-test-support
Added to bridge_server public API: BridgeResponse, read_line_bounded,
BridgeRequestCompat, BridgeParamsCompat, TpmSigningStorage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enclaveapp-*crates from the workspace — all consuming apps now use the publishedhardware-enclavecrate directlybridge_server:BridgeResponse,read_line_bounded,BridgeRequestCompat,BridgeParamsCompat,TpmSigningStorageWhat changed and why
All legacy path deps have been migrated:
enclaveapp-test-software/enclaveapp-core(sshencforce-software): replaced byhardware-enclave/mockMockSigner in sshenc PR #250enclaveapp-tpm-bridge(sshenc-tpm-bridge binary): now useshardware_enclave::bridge_server::BridgeServerdirectly (already public since v0.1.6)enclaveapp-core/enclaveapp-bridge(sshenc fuzz): now usehardware_enclave::bridge_server::{BridgeResponse, read_line_bounded}Deleted crates (recoverable from git history):
enclaveapp-core,enclaveapp-bridge,enclaveapp-windows,enclaveapp-windows-webauthn,enclaveapp-tpm-bridge,enclaveapp-test-software,enclaveapp-test-supportTest plan