BSc thesis "Coloring Data Race Interference Graphs"#2061
Draft
sim642 wants to merge 3 commits into
Draft
Conversation
sim642
added
feature
usability
student-job
setup
Comment on lines
+394
to
+396
| else | ||
| (); | ||
| () |
Member
There was a problem hiding this comment.
This should not be needed.
Comment on lines
+650
to
+667
| let coloring_for accs = | ||
| match coloring_mode with | ||
| | None -> None | ||
| | Some "greedy" -> | ||
| let graph = InterferenceGraph.of_accesses accs in | ||
| Some (InterferenceGraph.Coloring.color_with (module InterferenceGraph.Coloring.Greedy) graph) | ||
| | Some "dsatur" -> | ||
| let graph = InterferenceGraph.of_accesses accs in | ||
| Some (InterferenceGraph.Coloring.color_with (module InterferenceGraph.Coloring.Dsatur) graph) | ||
| | Some "rlf" -> | ||
| let graph = InterferenceGraph.of_accesses accs in | ||
| Some (InterferenceGraph.Coloring.color_with (module InterferenceGraph.Coloring.Rlf) graph) | ||
| | Some "optimal" -> | ||
| let graph = InterferenceGraph.of_accesses accs in | ||
| Some (InterferenceGraph.Coloring.color_with (module InterferenceGraph.Coloring.Optimal) graph) | ||
| | Some _ -> None | ||
| in | ||
| let msgs ?coloring race_accs = |
Member
There was a problem hiding this comment.
There should be a way to do this once instead of matching for every accs?
Comment on lines
+2459
to
+2465
| "race-coloring": { | ||
| "title": "warn.race-coloring", | ||
| "description": "Group race warnings by graph coloring (none, greedy, dsatur, rlf, optimal).", | ||
| "type": "string", | ||
| "enum": ["none", "greedy", "dsatur", "rlf", "optimal"], | ||
| "default": "none" | ||
| }, |
Member
There was a problem hiding this comment.
There should be some explanation of what this would achieve from a user-level perspective.
Comment on lines
+489
to
+495
| module Vertex = struct | ||
| type t = A.t | ||
|
|
||
| let compare = A.compare | ||
| let hash = A.hash | ||
| let equal = A.equal | ||
| end |
Member
There was a problem hiding this comment.
Why can vertices not be A directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation for an older BSc thesis in Tartu (in Estonian): https://thesis.cs.ut.ee/353b5994-7442-4681-989f-ea3e62ac21c2?language=en
I haven't reviewed the code myself, so this probably needs some cleanup first. I'm opening the PR such that this isn't completely forgotten.