Skip to content

Support Rails 7.2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Rails 7.2 #10

wants to merge 1 commit into from

Conversation

ajvondrak
Copy link

  • Bumped the gemspec to permit Rails 7.2.x
  • Required an update to the tests because ActiveRecord::Base.connection was deprecated in favor of ActiveRecord::Base.lease_connection and ActiveRecord::Base.with_connection: PoC: Add an option to disable connection checkout caching rails/rails#50793
  • The actual gem code doesn't call ActiveRecord::Base.connection, it's just used in test assertions
  • Confirmed the tests pass under Rails 7.2.2.1 locally

Copy link

@isnotajoke isnotajoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks similar to a prior PR doing something similar. I also looked through the gem code to confirm that nothing seemed to be relying on the changed method outside of specs (as noted in the description). Seems safe to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants