runtime/hints: add since() helper for hint templates #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a generic since(from,to) function to the hint template FuncMap that returns the number of seconds between two timestamps (to - from). This enables downstream services to conditionally show duration-aware hints (e.g., 'this may take a minute' for windows exceeding 6 months). The helper accepts RFC3339 strings and time.Time values, returning 0 on parse failure so hint rendering can proceed gracefully. Also expands AGENTS.md with repo-wide coding guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a generic
since(from,to)function to the hint template FuncMap that returns the number of seconds between two timestamps (to - from). This enables downstream services to conditionally show duration-aware hints (e.g., "this may take a minute" for windows exceeding 6 months).Changes
runtime/agent/runtime/hints/hints.go: Addsincehelper +parseTimestampsupporting RFC3339 strings andtime.Timevaluesruntime/agent/runtime/hints/hints_test.go: Table-driven tests forsinceviaCompileHintTemplatesAGENTS.md: Expand repo-wide coding guidelinesExample usage
Test evidence
make lint✅make test✅