fix(remote): verify the pinned checksum on remote cache hits - #2980
Merged
Conversation
A cache hit returned the cached Taskfile straight away, without ever comparing it to the checksum pinned on the include. The pin was only ever checked against freshly downloaded bytes, so a tampered cache entry bypassed it entirely. The same applies to the offline and cancelled download paths. A timestamp dated in the future also kept an entry valid past any expiry duration, since nothing bounded the value read back from disk.
vmaerten
changed the title
readNodeContent carried its own copy of the check, identical to the one now used on the cache paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cache hit returned the cached Taskfile straight away, without ever comparing it to the checksum pinned on the include. The pin was only ever checked against freshly downloaded bytes, so a tampered cache entry bypassed it entirely. The same applies to the offline and cancelled download paths.
A timestamp dated in the future also kept an entry valid past any expiry duration, since nothing bounded the value read back from disk.