Skip to content

Fix email scrubber hash input - #53

Open
5p2O5pe25ouT wants to merge 1 commit into
go-playground:masterfrom
5p2O5pe25ouT:fixbug/issue-45-email-scrub-hash
Open

5p2O5pe25ouT wants to merge 1 commit into
go-playground:masterfrom
5p2O5pe25ouT:fixbug/issue-45-email-scrub-hash

Conversation

@5p2O5pe25ouT

Copy link
Copy Markdown

Fixes #45

Summary

  • hash the email local part when using the emails scrubber
  • keep the existing behavior of replacing the local part and preserving the original domain
  • add coverage for multiple emails with the same domain so different local parts no longer collapse to the same scrub hash

Verification

  • RED: go test ./scrubbers -run TestEmails -count=1 failed before the fix because alice@example.com and bob@example.com produced the same hash
  • go test ./scrubbers -run TestEmails -count=1
  • go test ./...
  • git diff --check

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 94.695%. remained the same — 5p2O5pe25ouT:fixbug/issue-45-email-scrub-hash into go-playground:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maybe a bug, scrubs emails

2 participants