Remove invalid bigquery create callbacks#42
Open
takanuva15 wants to merge 1 commit into
Open
Conversation
takanuva15
force-pushed
the
master
branch
2 times, most recently
from
4118a21 to
82fad04
Compare
Author
|
@jinzhu Hi, request review on this PR to prevent invalid gorm syntax when creating records in BigQuery |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
BigQuery does not support
ON CONFLICTnorRETURNING. Thus it should not be available for the gorm create callbacks.User Case Description
gorm currently tries to include ON CONFLICT when saving/updating partial structs