Skip to content

Ignore "Close" error when uploading container blob #34620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Ignore "Close" error when uploading container blob #34620

merged 2 commits into from
Jun 9, 2025

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 6, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jun 6, 2025
Open
@wxiaoguang
Copy link
Contributor Author

Bug report from Sebclem (#34610 (comment))

500 error with version 1.24.0+rc0-51-g8defca6d39

#18 pushing git.***.fr/***/jellyfin-node-exporter:main with docker
#18 pushing layer 5f70bf18a086
#18 pushing layer 160d30915720
#18 pushing layer fd2758d7a50e
#18 pushing layer 5f70bf18a086 0.4s done
#18 pushing layer 160d30915720 0.4s done
#18 pushing layer fd2758d7a50e 0.4s done
#18 ERROR: received unexpected HTTP status: 500 Internal Server Error
------
 > pushing git.***.fr/***/jellyfin-node-exporter:main with docker:
------
ERROR: received unexpected HTTP status: 500 Internal Server Error

Gitea logs:

2025/06/06 10:33:11 .../container/container.go:92:apiError() [E] close /var/lib/gitea/data/tmp/package-upload/evugzlykjrvseozjsu85tqvmy: file already closed

But even if I retry it doesn't work. I don't know if this is also linked to the "manifest processing" issue.

You can find the project here if needed: https://git.sebclem.fr/sebclem/jellyfin-node-exporter
Dockerfile: https://git.sebclem.fr/sebclem/jellyfin-node-exporter/src/branch/main/Dockerfile
Latest run: https://git.sebclem.fr/sebclem/jellyfin-node-exporter/actions/runs/30

Also cc @KN4CK3R , this "Close" is the only suspicious call I found which would cause that error

@wxiaoguang wxiaoguang added the backport/v1.24 This PR should be backported to Gitea 1.24 label Jun 6, 2025
@wxiaoguang
Copy link
Contributor Author

@Sebclem if you could build your own binary, maybe you could try to apply this patch to see whether the bug could be fixed. Or you could wait for a moment for a nightly build after this PR gets approvals.

@Sebclem
Copy link

Sebclem commented Jun 6, 2025

ur own binary, maybe you could try to apply this patch to see whether the bug could be fixed. Or you could wait for a mo

I'm building it right now, I'll let you know if the issue is fixed 👍

@Sebclem
Copy link

Sebclem commented Jun 6, 2025

I can't run this build with my database backup, I have a migration version issue:
[F] Migration Error: Your database (migration version: 321) is for a newer Gitea, you can not use the newer database for this old Gitea release (313).
I suppose I'll way for this to be backported to 1.24.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jun 6, 2025 •
edited
Loading

If there is a "version" problem, you could apply the patch https://patch-diff.githubusercontent.com/raw/go-gitea/gitea/pull/34620.patch to 1.24 branch. The code base is the same.

@Sebclem
Copy link

Sebclem commented Jun 6, 2025

Oh yeah, I'm stupid, a little cherry-pick should work

@Sebclem
Copy link

Sebclem commented Jun 6, 2025

Ok, seams to fix the issue, workflow is back to green: https://git.sebclem.fr/sebclem/mc-update/actions/runs/91/jobs/0

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 9, 2025
@lunny lunny enabled auto-merge (squash) June 9, 2025 06:40
@lunny lunny merged commit 7a59f5a into go-gitea:main Jun 9, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 9, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 9, 2025
@wxiaoguang wxiaoguang deleted the fix-container-upload branch June 9, 2025 07:22
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 9, 2025
@wxiaoguang @GiteaBot
Ignore "Close" error when uploading container blob (go-gitea#34620)
3f11fdc
@GiteaBot GiteaBot mentioned this pull request Jun 9, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 9, 2025
wxiaoguang added a commit that referenced this pull request Jun 9, 2025
@GiteaBot @wxiaoguang
Ignore "Close" error when uploading container blob (#34620) (#34665)
fb4e9f9 
Backport #34620 by wxiaoguang

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
333545a 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix last admin check when syncing users (go-gitea#34649)
  Update x/crypto package and make builtin SSH use default parameters (go-gitea#34667)
  Fix "oras" OCI client compatibility (go-gitea#34666)
  Fix: skip paths check on tag push events in workflows (go-gitea#34602)
  Fix footnote jump behavior on the issue page. (go-gitea#34621)
  Only activity tab needs heatmap data loading (go-gitea#34652)
  Ignore "Close" error when uploading container blob (go-gitea#34620)
  Keeping consistent between UI and API about combined commit status state and fix some bugs (go-gitea#34562)
  Refactor FindOrgOptions to use enum instead of bool, fix membership visibility (go-gitea#34629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @Sebclem @lunny @hiifong @GiteaBot