Optimize team member ux #34593
Optimize team member ux #34593
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
| ctx.Data["Page"] = pager | ||
| ctx.Data["Teams"] = teams |
There was a problem hiding this comment.
TBH if you have "all teams" here, then the "pager" doesn't make sense any more.
| <a class="ui primary button" href="{{.OrgLink}}/teams/new">{{svg "octicon-plus"}} {{ctx.Locale.Tr "org.create_new_team"}}</a> | ||
| {{end}} | ||
| {{if .IsOrganizationMember}} | ||
| <a class="ui primary button" href="{{.OrgLink}}/teams">{{svg "octicon-people"}} {{ctx.Locale.Tr "org.all_teams"}}</a> |
There was a problem hiding this comment.
Isn't the "all teams" link already in the navbar?
There was a problem hiding this comment.
My original intention was to provide a more eye-catching entry on the secondary page.
| {{if or .IsOrganizationOwner .IsOrganizationMember}} | ||
| <div class="flex-text-block tw-justify-end tw-gap-x-1 tw-gap-y-2 tw-mb-4"> | ||
| {{if .IsOrganizationOwner}} | ||
| <a class="ui primary button" href="{{.OrgLink}}/teams/new">{{svg "octicon-plus"}} {{ctx.Locale.Tr "org.create_new_team"}}</a> |
There was a problem hiding this comment.
Why members list page should show "add new team"? I guess it should show "add new member" instead?
There was a problem hiding this comment.
Just like above, there is no mistake. It is indeed about adding a new team. My original intention is to provide a more eye-catching and convenient operation entry on the secondary page.
|
Before making more changes, I think there could be a better design, instead of adding the modal. The root problem is that "it is not clear about how to add a team member". To make it clear, we can just:
|
OK, I'll implement a version according to this train of thought and see the effect. |
Try to solve #22054