-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Migrate to urfave v3 #34510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to urfave v3 #34510
Conversation
ensure flags don't carry state through tests
patch smtp idflag persisting
update copyright date and remove traceline
171eab9
to
d4a27cb
Compare
Made some changes by accident. Reset to your latest change by force push. I think we need to make more changes like this, proposed a PR to your fork (or could I update this PR?) |
Don't call newAuthService in init stage
At this stage I won't mind if you do it directly. It's more of a draft thing I guess. |
Maybe we can utilize the GitHub's "allow maintainer to edit" checkbox. If you would like to keep the PR WIP and don't want others to edit, uncheck it. When it is ready for review and accepts edits, check it. 🤔 |
That... would be smart... Noted. |
migrate cli to urfave v3
add more cli tests