Migrate to urfave v3 #34510

TheFox0x7 · 2025-05-20T22:32:32Z

migrate cli to urfave v3

add more cli tests

ensure flags don't carry state through tests

patch smtp idflag persisting

cmd/cert.go

cmd/main.go

cmd/admin_auth_ldap.go

cmd/admin_user_delete_test.go

cmd/cert.go

cmd/cmd.go

cmd/cert.go

update copyright date and remove traceline

cmd/cert.go

wxiaoguang · 2025-06-10T02:10:23Z

Made some changes by accident. Reset to your latest change by force push.

I think we need to make more changes like this, proposed a PR to your fork (or could I update this PR?)

Don't call newAuthService in init stage TheFox0x7/gitea#2

Don't call newAuthService in init stage

TheFox0x7 · 2025-06-10T06:47:59Z

I think we need to make more changes like this, proposed a PR to your fork (or could I update this PR?)

At this stage I won't mind if you do it directly. It's more of a draft thing I guess.
I got annoyed before as I had some changes that I have not committed which I would need to merge with yours which at the time seemed like it will take me a while (it did not). Though in retrospect it's good that you did it because you accidentally stopped me from overscoping this PR into a refactor.
So thanks :)

wxiaoguang · 2025-06-10T12:09:24Z

At this stage I won't mind if you do it directly. It's more of a draft thing I guess.

Maybe we can utilize the GitHub's "allow maintainer to edit" checkbox. If you would like to keep the PR WIP and don't want others to edit, uncheck it. When it is ready for review and accepts edits, check it. 🤔

TheFox0x7 · 2025-06-10T12:12:37Z

Maybe we can utilize the GitHub's "allow maintainer to edit" checkbox. If you would like to keep the PR WIP and don't want others to edit, uncheck it. When it is ready for review and accepts edits, check it. 🤔

That... would be smart... Noted.

TheFox0x7 added 6 commits May 18, 2025 16:51

migrate to urfave v3

d281b11

inline flags for ldap commands

df9c7f2

ensure flags don't carry state through tests

align tests

d29b785

add tests for smtp command

ffd04d0

add oauth coverage

553b43a

patch smtp idflag persisting

fix formatting

69cde4d

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2025

github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/internal modifies/dependencies labels May 20, 2025

TheFox0x7 and others added 9 commits May 23, 2025 22:35

install signals in main

4ae57e8

add coverage for cert subcommand

eba1408

add coverage for admin user delete command

173ad6c

add coverage for change password

13b9d6e

add coverage for must change password

02497c0

drop argsSet in favor of required

8e2333f

Merge branch 'main' into migrate-to-urfave-v3

97589cf

fix

23dd90f

Merge branch 'main' into migrate-to-urfave-v3

70deea2

wxiaoguang reviewed Jun 4, 2025

View reviewed changes

cmd/cert.go Show resolved Hide resolved

fix

dfd47ce

wxiaoguang reviewed Jun 4, 2025

View reviewed changes

cmd/main.go Outdated Show resolved Hide resolved

wxiaoguang reviewed Jun 4, 2025

View reviewed changes

cmd/main.go Outdated Show resolved Hide resolved

wxiaoguang added 4 commits June 4, 2025 18:42

fix

cda23a7

fix

c47d666

fix name, fix lint

9441550

fix

b2d5244

wxiaoguang reviewed Jun 4, 2025

View reviewed changes

cmd/admin_auth_ldap.go Outdated Show resolved Hide resolved

wxiaoguang reviewed Jun 4, 2025

View reviewed changes

cmd/admin_auth_ldap.go Show resolved Hide resolved

GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 8, 2025

wxiaoguang added this to the 1.25.0 milestone Jun 8, 2025

wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jun 8, 2025