Add post-installation redirect based on admin account status #34493
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
There was a problem hiding this comment.
Can't speak on frontend design, but otherwise this looks good to me.
Was iffy about the HasUsers() calls ignoring DB errors, but after further reading it seems the worst that can happen is:
- User accesses sign up page (or completes the install config if they're on the install page)
- A DB error occurs
- Server sends sign up page + the
sign_up_tipmessage to the user
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
denyskon
added
type/enhancement
options/locale/locale_en-US.ini
Outdated
| @@ -421,6 +421,7 @@ remember_me.compromised = The login token is not valid anymore which may indicat | |||
| forgot_password_title= Forgot Password | |||
| forgot_password = Forgot password? | |||
| need_account = Need an account? | |||
| sign_up_tip = You are registering the first account in the system. Please carefully remember your username and password, as losing this information could cause significant inconvenience later. | |||
There was a problem hiding this comment.
It is an unclear message. For example: why the "first account" is special? What "significant inconvenience" would happen? If it is not clean, it only confuses or frightens end users.
There was a problem hiding this comment.
Let's see if the new tip is appropriate.
|
And also please review admin related bug fix: Fix last admin check when syncing users #34649 |
| @@ -421,6 +421,7 @@ remember_me.compromised = The login token is not valid anymore which may indicat | |||
| forgot_password_title= Forgot Password | |||
| forgot_password = Forgot password? | |||
| need_account = Need an account? | |||
| sign_up_tip = You are registering the first account in the system, which has administrator privileges. Please carefully remember your username and password, as forgetting these credentials may require system reset and reinitialization. | |||
There was a problem hiding this comment.
as forgetting these credentials may require system reset and reinitialization.
That's not true, site admin can use gitea CLI to reset user password
There was a problem hiding this comment.
You are registering the first account in the system. Please remember your username and password, as this account typically has administrative privileges. How about this? Is it okay?
This PR adds a feature to direct users to appropriate pages after system installation: