tests: add NSTextView typing-attributes tests#490
Merged
fredkiefer merged 2 commits intoJul 13, 2026
Conversation
DTW-Thalion
force-pushed
the
tests/nstextview-typingattributes
branch
3 times, most recently
from
2412678 to
4cc84e8
Compare
Cover the typing attributes and related state: the defaults, the string, the way setFont: and setTextColor: update the typing attributes, setTypingAttributes:, and the editable/selectable coupling.
DTW-Thalion
force-pushed
the
tests/nstextview-typingattributes
branch
from
4cc84e8 to
faaa2da
Compare
fredkiefer
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSTextView had no coverage of its typing attributes. This adds tests for
the typing attributes and related state: the defaults (editable,
selectable, rich text, field editor, draws background), that the typing
attributes carry a font and a foreground colour, the string, the way
setFont: and setTextColor: update the typing attributes,
setTypingAttributes:, and the editable/selectable coupling (an editable
view is always selectable; a non-selectable one is not editable). The
asserted defaults and behaviours were checked against a macOS runner. No
source changes; all assertions pass.