-
Notifications
You must be signed in to change notification settings - Fork 413
fix(gnovm): Error messages should display the actual package path where the error occurs #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please resolve the conflicts? It seems your branch has been outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test does not reproduce the issue. It only detecting errors within the same package, which is functionality that currently works. The Bar
function should be in a different package (maybe pkg2
?) rather than pkg1
, and pkg2
should call the pkg1.Foo
function.
Please refer to this test for how to create multiple packages within txtar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notJoon i will check again
fix ( gnovm) : Error messages should display the actual package path where the error occurs #4295
It resolve issue #4295
Can see error from root path