Skip to content

Client formatting hooks #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: v1_8_0
Choose a base branch
from
Draft

Client formatting hooks #187

wants to merge 1 commit into from

Conversation

gmac
Copy link
Owner

@gmac gmac commented Jun 9, 2025

Reorganize formatting hooks (composition mergers, error formatters, etc) into a concern that can be added to various objects. All output formatting methodology is now centralized on one object, and allows Client to be that object.

Breaking changes

  • Removes description_merger composer option. Override merge_descriptions client method.
  • Removes deprecation_merger composer option. Override merge_deprecations client method.
  • Removes default_value_merger composer option. Override merge_default_values client method.
  • Removes directive_kwarg_merger composer option. Override merge_kwargs client method.
  • Removes root_field_location_selector composer option. Use root_entrypoints composer option.
  • Return from on_error hook no longer populates GraphQL error message. Override build_graphql_error client method to build the desired error shape.

@gmac gmac force-pushed the formatter_class branch from ce3352e to d979d6c Compare June 9, 2025 12:20
@gmac gmac changed the base branch from main to v1_8_0 June 9, 2025 12:21
@gmac gmac changed the title Stitching Client formatting Client formatting hooks Jun 9, 2025
@gmac gmac mentioned this pull request Jun 9, 2025
@gmac gmac force-pushed the formatter_class branch from d979d6c to 4675dab Compare June 9, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant