Skip to content

Conversation

@jpsilkjr86
Copy link
Collaborator

Included changes:

  • Updated ordersV0 model with latest SP-API changes in 2024 and 2025;
  • Regenerated OpenAPI models and client utility classes against the updated ordersV0 API model;
  • Identified and mitigated breaking changes introduced by SP-API model in IsGift and IsBuyerRequestedCancel:
    • On April 25, 2024 via commit d58ccf3dd42, Amazon appears to have changed the datatype of IsBuyerRequestedCancel and IsGift from bools to strings -- i.e. instead of the bools true and false, the strings 'true' and 'false' are now reflected in the JSON schema. It is unclear whether Amazon is introducing a breaking change here, or whether they are simply updating the model to reflect the actual (buggy) return values of the strings 'true' and 'false'. In order to mitigate breaking changes experienced by consumers of this package, and in anticipation of Amazon potentially silently changing these back to proper bools in the future, the decision was made to preserve the original bool datatype, as the ObjectSerializer utility already contains custom logic to handle converting the strings 'true' and 'false' to bools via filter_var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants