Skip to content

Add subscription for ask glific resposne#3886

Open
AmishaBisht wants to merge 19 commits into
masterfrom
ask_glific/sse
Open

Add subscription for ask glific resposne#3886
AmishaBisht wants to merge 19 commits into
masterfrom
ask_glific/sse

Conversation

@AmishaBisht
Copy link
Copy Markdown
Collaborator

@AmishaBisht AmishaBisht commented Apr 9, 2026

issue: glific/glific#4950

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced AskGlific, an enhanced chat interface replacing the previous version with support for three display modes: floating, sidebar, and fullscreen views.
    • Added chat history panel with date-grouped conversations for easy navigation.
    • Implemented user feedback mechanism (thumbs up/down) on chat responses.
    • Added Markdown rendering for chat responses with external link support.
  • Tests

    • Added comprehensive test coverage for AskGlific functionality.
  • Chores

    • Removed deprecated chat component and related configurations.

akanshaaa19 and others added 15 commits March 31, 2026 13:18
…ments

- Updated AskMeBot component to include feedback buttons for user responses.
- Added new chat functionality to reset the conversation.
- Improved test cases for AskMeBot to cover new features.
- Introduced a mock chat history for better user experience.
- Refactored AskMeBot styles and layout for improved usability.
- Added new SVG icon for AskMeBot branding.
- Updated AssistantOptions and CreateAssistant components to reflect changes in vector store handling.
@AmishaBisht AmishaBisht marked this pull request as draft April 9, 2026 17:53
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c58f0786-fb4f-4129-bd88-8d8e144a6a05

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR replaces the AskMeBot chat implementation with a new AskGlific system. The changes include removing the AskMeBot component, styles, and tests; adding a new AskGlific React container with CSS module and test suite; updating GraphQL mutations and subscriptions to support the new backend service; renaming organization service configuration flags from askMeBotEnabled to askGlificEnabled across service types and queries; and updating routing and workflow configuration to reference the new component and branch checkout respectively.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~65 minutes

Possibly related PRs

  • Ask me bot #3509: Directly related—this PR replaces the AskMeBot implementation that was introduced in #3509 with the new AskGlific feature (deleting AskMeBot files, removing ASK_ME_BOT_ENDPOINT, renaming service flags, and adding ASK_GLIFIC GraphQL mutations/subscriptions).
  • Ask Glific: UI  #3862: Main PR is directly related—both replace AskMeBot with AskGlific implementation (adding AskGlific component, CSS module, tests, and updating organization service flags).
  • Refactor: cypress file #3675: Related to workflow configuration—both modify the same .github/workflows/cypress-testing.yml checkout step for backend repository branch management.

Suggested labels

status: ready for review

Suggested reviewers

  • akanshaaa19
  • shijithkjayan
  • mdshamoon

Poem

🐰 A new chat friend arrives with flair and grace,
Replacing old AskMeBot in its place—
With Glific's mutations and subscriptions bright,
The conversation flows with pure delight!
GraphQL spins, the CSS gleams so green,
The finest Ask experience yet seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions adding a subscription for ask glific response, which is only one aspect of a much larger changeset that includes replacing AskMeBot with AskGlific component, adding new UI/styling, tests, mutations, and refactoring multiple files. Consider revising the title to reflect the primary change: replacing AskMeBot with AskGlific component and integrating the chat functionality across the application.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ask_glific/sse

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

@github-actions github-actions Bot temporarily deployed to pull request April 9, 2026 17:55 Inactive
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 9, 2026

Not up to standards ⛔

🔴 Issues 3 high · 2 medium · 1 minor

Alerts:
⚠ 6 issues (≤ 0 issues of at least minor severity)

Results:
6 new issues

Category Results
BestPractice 2 medium
1 minor
ErrorProne 3 high

View in Codacy

🟢 Metrics 18 complexity

Metric Results
Complexity 18

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ask-glific@98c9d54). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/containers/AskGlific/AskGlific.tsx 55.55% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             ask-glific    #3886   +/-   ##
=============================================
  Coverage              ?   81.92%           
=============================================
  Files                 ?      313           
  Lines                 ?    13208           
  Branches              ?     3064           
=============================================
  Hits                  ?    10820           
  Misses                ?     1427           
  Partials              ?      961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 9, 2026

Glific    Run #8465

Run Properties:  status check failed Failed #8465  •  git commit 12ffa72e1b ℹ️: Merge 193e648268c5e987acd7286d3013bdf5d9d7016f into 98c9d54c0a30b0765e53aea82771...
Project Glific
Branch Review ask_glific/sse
Run status status check failed Failed #8465
Run duration 22m 31s
Commit git commit 12ffa72e1b ℹ️: Merge 193e648268c5e987acd7286d3013bdf5d9d7016f into 98c9d54c0a30b0765e53aea82771...
Committer Amisha Bisht
View all properties for this run ↗︎

Test results
Tests that failed  Failures 18
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/filesearch/Filesearch.spec.ts • 18 failed tests

View Output

Test Artifacts
File search > should create a new assistant with file upload Test Replay Screenshots
File search > should ensure assistant status changes to ready Test Replay Screenshots
File search > should display assistants in the list Test Replay Screenshots
File search > should search for the created assistant by name Test Replay Screenshots
File search > should clear search and restore the full list Test Replay Screenshots
File search > should copy assistant item ID from the list Test Replay Screenshots
File search > should select an assistant and display its details in the form Test Replay Screenshots
File search > should display knowledge base details for the selected assistant Test Replay Screenshots
File search > should copy assistant ID from the edit form Test Replay Screenshots
File search > should show unsaved changes indicator when name is modified Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.
Flakiness  cypress/e2e/chat/ChatCollection.spec.ts • 1 flaky test

View Output

Test Artifacts
ChatCollection > should send the emoji to collection Test Replay Screenshots

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Introduced Ask Glific chat assistant with floating, sidebar, and
fullscreen modes, chat history panel, and New Chat action; per-response
feedback controls.

* **Improvements**
* Redesigned chat UI: welcome screen, suggestion cards, auto-resizing
textarea, updated message styling, thinking/loading indicator,
minimize/restore behavior, and improved history interactions.

* **Tests**
* Added/updated tests covering chat flows, suggestion-based sending,
feedback controls, history, and display-mode behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@AmishaBisht AmishaBisht marked this pull request as ready for review April 10, 2026 04:42
@AmishaBisht AmishaBisht changed the base branch from master to ask-glific April 10, 2026 04:42
Comment on lines +3 to +9
<<<<<<< ask_glific/sse
import * as Apollo from '@apollo/client';
import { ASK_GLIFIC } from 'graphql/mutations/AskGlific';
=======
import { ASK_GLIFIC, ASK_GLIFIC_FEEDBACK } from 'graphql/mutations/AskGlific';
import { GET_ASK_GLIFIC_CONVERSATIONS, GET_ASK_GLIFIC_MESSAGES } from 'graphql/queries/AskGlific';
>>>>>>> ask-glific
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from ask-glific to master May 7, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants