Skip to content

Use reusable containers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bsideup
Copy link

@bsideup bsideup commented Apr 5, 2024

Hey @glaforge! Excited to have you review my PRs again 😊
(Context: @glaforge welcomed me to the Groovy community ~10 years ago)

Testcontainers allows containers to be reused between the sessions, enabling much faster iterations (e.g. after this change, CallGemma runs in 5s on Testcontainers Cloud, vs 13s without it).

The proposed change shows how to use it. No pressure if you want to keep the image-based approach, nothing is wrong with it, just it is slower because, each time you run the test, it will start the container, even if the model is already pre-pulled.

@glaforge
Copy link
Owner

@bsideup by the way, I'm curious when this reusable feature will become generally available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants