Replace sklearn.externals.six with six #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly after setting it up as a project dependency
Author
ChristopherBilg
approved these changes
Feb 13, 2023
Contributor
ChristopherBilg
left a comment
ChristopherBilg
left a comment
There was a problem hiding this comment.
This works with my current projects. 👍
Contributor
|
@pasusarla Please do not close and reopen pull requests to ping people. |
Author
|
@ChristopherBilg my apologies! It was an unfortunate stray click. I'll be careful. Thanks for your understanding! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent move from sklearn to scikit-learn (via PR #65), it became necessary to import six directly.
@gkhayes @ChristopherBilg May I request you to please consider?