ipfs: Fix for latest IPFS API language#14
Open
kallisti5 wants to merge 1 commit into
Open
Conversation
* Fixes library to work with latest API version from IPFS. The API requests all changed to POST from GET (even where POST doesn't make sense) * Interesting IPFS completely changed the API, but didn't bump v0 to v1 :-| * This breaks compatibility with any old versions (0.9.0 or before) but makes the crate work with recent versions (0.10.0 - 0.13.0)
Author
|
This one will solve #12 That was run on a IPFS 0.12.x node. |
Author
|
@gkbrk any interest in turning the rust crate over to me to maintain if you no longer have time for this project? You can add an owner on crates.io. Add Owner -> kallisti5 |
Owner
I don't think we should care about those versions. Most likely they won't be able to interoperate with the rest of the IPFS network as they extend and change the protocol anyway. Even if they don't, it's not a good security practice to run those versions I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from IPFS. The API requests all changed to POST from GET
(even where POST doesn't make sense)
bump v0 to v1 :-|
(0.9.0 or before) but makes the crate work with recent
versions (0.10.0 - 0.13.0)