Simplify (hopefully) code for moving selection in filetreelist#2645
Merged
extrawurst merged 1 commit intoMay 20, 2025
Merged
Conversation
5593c2f to
0153e56
Compare
extrawurst
reviewed
May 20, 2025
Collaborator
|
looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential follow-up to #2496.
It changes the following:
get_new_selectionas the single function that iterates over the list’s items to get the next selection based on a range and a step size.enum Directionas a more explicit alternative toup: bool.The only thing I’m worried about is that the ranges passed as arguments to
get_new_selectionpotentially are too clever or unintuitive. If you think that’s an argument against this PR as a whole, feel free to close it! 😄 I still wanted to open it in order to get your feedback.I followed the checklist:
make checkwithout errors