Skip to content

feat: Add Pull mirror API (#1227) #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add Pull mirror API (#1227) #1271

wants to merge 1 commit into from

Conversation

Jony-Jas
Copy link
Contributor

Closes #1227

Created PullMirror model and get methods to support the PullMirror API endpoint

  • List getPullMirrors(final Object projectIdOrPath)
  • Pager getPullMirrors(final Object projectIdOrPath, int itemsPerPage)

jmini
jmini requested changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a small addition is needed

gitlab4j-models/src/main/java/org/gitlab4j/api/models/PullMirror.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a JSON example (often I take the one from the documentation) in gitlab4j-models/src/test/resources/org/gitlab4j/models/ and a test case in TestGitLabApiBeans?

If you need more information feel free to continue this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add "Pull mirror API"
2 participants
@Jony-Jas @jmini