test: remove duplicate PR-filter dependsOn test - #1794
Draft
github-actions[bot] wants to merge 1 commit into
Draft
test: remove duplicate PR-filter dependsOn test#1794github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite Reduction: tests/compiler_tests.rs (lines 5140-5650)
What was wrong
test_pr_filter_agent_depends_on_setupasserted only that the Agent job'sdependsOn: Setupand its condition referenceprGate.SHOULD_RUN. Both properties are already exercised, more precisely, bytest_pr_filter_synth_mode_agent_condition_enforces_gate(same fixturepr-filter-tier1-agent.md), which asserts the full gate-enforcing condition shape (ne(Build.Reason, 'PullRequest'),ne(synthPr.AW_SYNTHETIC_PR, 'true'),eq(prGate.SHOULD_RUN, 'true')) and explicitly guards against the historical gate-bypass regression. The smaller test's coverage was a strict subset.Changes
test_pr_filter_agent_depends_on_setuptest_pr_filter_synth_mode_agent_condition_enforces_gatetest_pr_filter_synth_mode_agent_condition_enforces_gatedependsOn: Setupcheck from the removed test so no coverage was lostVerification
cargo test: all 220 compiler_tests pass ✅ (was 221; net -1 test, no coverage lost)cargo clippy --all-targets --all-features: no warnings ✅Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.