Skip to content

test: remove duplicate PR-filter dependsOn test - #1794

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
test-reducer/pr-filter-dedup-d53ae68ba15271ea
Draft

test: remove duplicate PR-filter dependsOn test#1794
github-actions[bot] wants to merge 1 commit into
mainfrom
test-reducer/pr-filter-dedup-d53ae68ba15271ea

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Test Suite Reduction: tests/compiler_tests.rs (lines 5140-5650)

What was wrong

  • test_pr_filter_agent_depends_on_setup asserted only that the Agent job's dependsOn: Setup and its condition reference prGate.SHOULD_RUN. Both properties are already exercised, more precisely, by test_pr_filter_synth_mode_agent_condition_enforces_gate (same fixture pr-filter-tier1-agent.md), which asserts the full gate-enforcing condition shape (ne(Build.Reason, 'PullRequest'), ne(synthPr.AW_SYNTHETIC_PR, 'true'), eq(prGate.SHOULD_RUN, 'true')) and explicitly guards against the historical gate-bypass regression. The smaller test's coverage was a strict subset.

Changes

Test Action Reason
test_pr_filter_agent_depends_on_setup Removed Strict subset of test_pr_filter_synth_mode_agent_condition_enforces_gate
test_pr_filter_synth_mode_agent_condition_enforces_gate Extended Folded in the dependsOn: Setup check from the removed test so no coverage was lost

Verification

  • cargo test: all 220 compiler_tests pass ✅ (was 221; net -1 test, no coverage lost)
  • cargo clippy --all-targets --all-features: no warnings ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · aut00 · 119.6 AIC · ⌖ 11.9 AIC · ⊞ 12.9K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants