fix actions but better#192
Closed
mhamza15 wants to merge 2 commits intorelease-21.0-githubfrom
Closed
Conversation
This reverts commit e960570.
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
6fec1c2 to
f013d1d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow configurations to use self-hosted runners for the vitessio organization while falling back to Ubuntu runners for forks. The change affects both template files and generated workflow files.
- Replaces hardcoded
ubuntu-24.04runner with conditional runner selection - Updates template files to use dynamic runner assignment based on repository ownership
- Applies the same conditional logic across all workflow files for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/templates/*.tpl | Updated template files to use conditional runner logic |
| .github/workflows/*.yml | Applied conditional runner assignment to all workflow files |
Comments suppressed due to low confidence (3)
test/templates/cluster_endtoend_test_mysql57.tpl:1
- The conditional template logic
{{if .Cores16}}gh-hosted-runners-16cores-1-24.04{{else}}gh-hosted-runners-16cores-1-24.04{{end}}produces the same output in both branches. This redundant logic should be simplified to justgh-hosted-runners-16cores-1-24.04.
name: {{.Name}}
test/templates/cluster_endtoend_test_docker.tpl:1
- The conditional template logic
{{if .Cores16}}gh-hosted-runners-16cores-1-24.04{{else}}gh-hosted-runners-16cores-1-24.04{{end}}produces the same output in both branches. This redundant logic should be simplified to justgh-hosted-runners-16cores-1-24.04.
name: {{.Name}}
test/templates/cluster_endtoend_test.tpl:1
- The conditional template logic
{{if .Cores16}}gh-hosted-runners-16cores-1-24.04{{else}}gh-hosted-runners-16cores-1-24.04{{end}}produces the same output in both branches. This redundant logic should be simplified to justgh-hosted-runners-16cores-1-24.04.
name: {{.Name}}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes