Set parsed comments in operator for subqueries (#18369)#191
Set parsed comments in operator for subqueries (#18369)#191mhamza15 wants to merge 4 commits intorelease-22.0-githubfrom
Conversation
Signed-off-by: David Piegza <davidpiegza@github.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request ensures that parsed comments are properly preserved when merging subqueries with outer queries in the Vitess query planner. The change specifically sets the comments from the outer Route operator to the merged operator when subqueries are merged.
- Preserves SQL comments during subquery merging operations
- Adds test coverage for comment handling in various subquery scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/vt/vtgate/planbuilder/operators/subquery_planning.go | Adds logic to preserve comments from outer Route when merging subqueries |
| go/vt/vtgate/planbuilder/testdata/select_cases.json | Adds test cases to verify comment preservation in subquery scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* fix actions Signed-off-by: Mohamed Hamza <mhamza15@github.com> * fix actions --------- Signed-off-by: Mohamed Hamza <mhamza15@github.com>
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
Description
This is a backport of vitessio#18369
Related Issue(s)
Checklist
Deployment Notes