Allow the use of db credentials when verifying unmanaged tablets conf…#189
Merged
mhamza15 merged 1 commit intorelease-20.0-githubfrom Aug 22, 2025
Merged
Conversation
…ig (vitessio#17984) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
There was a problem hiding this comment.
Pull Request Overview
This PR enables the use of database credentials from a credentials file when verifying unmanaged tablet configurations. It backports functionality that allows tablets to fall back to credential files when passwords are not explicitly provided in configuration.
- Modified the unmanaged tablet configuration verification to check for credentials via
GetCredentialsServer()when password is empty - Added a test utility function to set credential file paths for testing purposes
- Added test coverage for the new credential fallback functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go/vt/vttablet/tabletserver/tabletenv/config.go | Updated verification logic to fetch passwords from credentials server when not provided |
| go/vt/dbconfigs/credentials.go | Added test utility function to set credential file path |
| go/vt/vttablet/tabletserver/tabletenv/config_test.go | Added test case for credential file fallback behavior |
| go/vt/vttablet/tabletserver/tabletenv/data/db_credentials.json | Added test credential file with sample user/password |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ig (vitessio#17984)
This is a backport of vitessio#17984
Description
Related Issue(s)
Checklist
Deployment Notes