allow innodb_lock_wait_timeout as system variable (#16574)#188
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the innodb_lock_wait_timeout system variable by moving it from the read-only variables list to the settable variables list, enabling it to be modified at the session level.
- Moves
innodb_lock_wait_timeoutfrom read-only to settable system variables - Updates AST rewriting to exclude global scope variables from rewriting
- Adds comprehensive test coverage for both session and global variable behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go/vt/sysvars/sysvars.go | Moves innodb_lock_wait_timeout from read-only to settable variables list |
| go/vt/sqlparser/ast_rewriting.go | Updates variable rewriting logic to exclude global scope variables |
| go/vt/vtgate/executor_set_test.go | Adds unit tests for setting innodb_lock_wait_timeout |
| go/vt/vtgate/executor_select_test.go | Adds comprehensive test for global vs session variable behavior |
| go/test/endtoend/vtgate/reservedconn/sysvar_test.go | Adds end-to-end test for innodb_lock_wait_timeout functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of vitessio#16574
Related Issue(s)
Checklist
Deployment Notes