remove spokes_receive_pack_isolated_reference_discovery feature flag - #126
Open
znull wants to merge 1 commit into
Open
remove spokes_receive_pack_isolated_reference_discovery feature flag#126znull wants to merge 1 commit into
znull wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the fully enabled isolated reference-discovery feature flag and deletes the legacy implementation.
Changes:
- Makes isolated reference discovery unconditional.
- Removes obsolete synchronization and flag-specific tests.
- Retains coverage for standard and unhidden-reference discovery.
Show a summary per file
| File | Description |
|---|---|
internal/spokes/spokes.go |
Removes feature-flag branching and legacy discovery code. |
internal/spokes/spokes_test.go |
Simplifies tests for the remaining implementation. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been fully enabled for quite some time.
/cc @newren