Buffer receive-pack reference advertisements - #125
Open
znull wants to merge 2 commits into
Open
Conversation
Reference discovery emits each pkt-line as separate header and payload writes. Buffer discovery up through its terminating flush packet, and serialize the legacy concurrent collectors so direct socket transports still have coherent packet framing.
git's next branch now builds libgitcore with rust.
There was a problem hiding this comment.
Pull request overview
Buffers reference advertisements to reduce socket writes while preserving pkt-line framing across concurrent collectors.
Changes:
- Buffers and flushes reference discovery output.
- Serializes legacy concurrent advertisement writes.
- Adds buffering/concurrency tests and installs Cargo in CI.
Show a summary per file
| File | Description |
|---|---|
internal/spokes/spokes.go |
Implements buffered, synchronized reference advertisement. |
internal/spokes/spokes_test.go |
Tests both discovery paths and concurrent collectors. |
.github/workflows/go-test.yml |
Adds Cargo required for the Git build. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference discovery writes each advertised ref as a separate pkt-line header and payload. When the caller hands
spokes-receive-packa TCP socket directly, that creates millions of tiny socket writes.This change buffers only the reference-advertisement phase through its terminating flush packet. The legacy non-isolated discovery pipeline starts collectors concurrently, so their shared capability decision and complete pkt-line writes are serialized to preserve framing.
Benchmarking and tracing shows reduced spokes writes from ~11.0M to ~8.8k and client reads from ~7.1M to ~90k for the benchmark window.