calculate new commit oids on each push

[brad-swenson]

Compare all the commit oids in the quarantine packfiles to the existing repository and save all the new commit oids into objects/<quarantine_id>/new_objects_<quarantine_id>.

[Copilot]

Pull request overview

Adds support for computing commit OIDs that are newly introduced by a push (present in the quarantine object directory but not in the main repo) and persisting them as a file in the quarantine directory, along with test coverage and a fixture repo to exercise the behavior.

Changes:

• Invoke writeNewCommitOIDs() after a successful pack ingest to write objects/<quarantine_id>/new_objects_<quarantine_id>.
• Implement writeNewCommitOIDs() using git cat-file pipelines to find commit objects missing from the main repo.
• Add a unit test plus a bare-repo fixture (testdata/quarantine-new-commit.git) containing both main and quarantined pack data.

Reviewed changes

Copilot reviewed 9 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/spokes/spokes.go	Calls new OID writer during push execution and adds writeNewCommitOIDs() implementation.
internal/spokes/spokes_test.go	Adds TestWriteNewCommitOIDs validating the generated new_objects_<id> file.
internal/spokes/testdata/quarantine-new-commit.git/HEAD	Fixture repo HEAD reference.
internal/spokes/testdata/quarantine-new-commit.git/config	Fixture repo config for bare repository.
internal/spokes/testdata/quarantine-new-commit.git/description	Fixture repo description file.
internal/spokes/testdata/quarantine-new-commit.git/info/exclude	Fixture repo default exclude file.
internal/spokes/testdata/quarantine-new-commit.git/info/refs	Fixture repo advertised refs for the main branch.
internal/spokes/testdata/quarantine-new-commit.git/objects/info/commit-graph	Fixture commit-graph supporting object enumeration.
internal/spokes/testdata/quarantine-new-commit.git/objects/info/packs	Fixture pack listing for main repo objects.
internal/spokes/testdata/quarantine-new-commit.git/objects/pack/pack-26638a754743afcd6af4c06077541c5c8cbf8610.bitmap	Fixture bitmap for main repo pack.
internal/spokes/testdata/quarantine-new-commit.git/objects/pack/pack-26638a754743afcd6af4c06077541c5c8cbf8610.idx	Fixture index for main repo pack.
internal/spokes/testdata/quarantine-new-commit.git/objects/pack/pack-26638a754743afcd6af4c06077541c5c8cbf8610.pack	Fixture pack containing main repo objects.
internal/spokes/testdata/quarantine-new-commit.git/objects/pack/pack-26638a754743afcd6af4c06077541c5c8cbf8610.rev	Fixture reverse index for main repo pack.
internal/spokes/testdata/quarantine-new-commit.git/objects/1/pack/pack-d0b1efac99b5d57732198f0c3b7d62dd598e91f5.idx	Fixture index for quarantined pack objects.
internal/spokes/testdata/quarantine-new-commit.git/objects/1/pack/pack-d0b1efac99b5d57732198f0c3b7d62dd598e91f5.pack	Fixture quarantined pack containing the “new” commit object(s).
internal/spokes/testdata/quarantine-new-commit.git/objects/1/pack/pack-d0b1efac99b5d57732198f0c3b7d62dd598e91f5.rev	Fixture reverse index for quarantined pack.
internal/spokes/testdata/quarantine-new-commit.git/packed-refs	Fixture packed refs for main branch.

Comments suppressed due to low confidence (1)

internal/spokes/spokes_test.go:301

• The test removes new_objects_1 without checking the returned error, and cleanup only happens at the end of the test body. Consider using t.Cleanup (and checking errors) so the file is removed even if an assertion fails earlier, preventing testdata pollution between runs.

	os.Remove(filepath.Join(wd, "objects", "1", "new_objects_1"))
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[migue]

The changes look reasonable to me