test(presets): normalize whitespace in resolve output assertion to prevent terminal line-wrap failures - #4166
Merged
Conversation
…event terminal line-wrap failures Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes whitespace in preset resolver test output to prevent failures caused by Rich terminal wrapping.
Changes:
- Removes output whitespace before checking for
constitution.md.
Show a summary per file
| File | Description |
|---|---|
tests/test_presets.py |
Makes the dotted-command assertion terminal-width independent. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_presets.py::TestInstalledPresetRichMarkup::test_resolve_accepts_dotted_command_name, the assertionassert "constitution.md" in strip_ansi(result.output)failed when running in environments with constrained terminal column widths or long paths because Rich console output wrappedtemplates/commands/constituti\non.mdacross lines.