Test stability - #252
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Ensures proxy state does not leak between randomized tests.
Changes:
- Resets the global proxy after the proxy-setting test.
Show a summary per file
| File | Description |
|---|---|
spec/github_pages_health_check_spec.rb |
Adds proxy-state cleanup. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Harshan01
enabled auto-merge
August 13, 2026 19:16
Harshan01
force-pushed
the
users/harshan01/test-stability
branch
from
August 13, 2026 19:23
4597e39 to
f2b8955
Compare
nishtha4894
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset proxy state after the test that modifies it.