Complete Cloud Hypervisor runtime compilation - #52588
Conversation
Compile the privileged strict-isolation AWF host invocation, scoped KVM access, verified virtiofsd release bundle contract, MCP gateway topology, viable guest sizing, and timeout propagation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Completes compiler support for AWF’s Cloud Hypervisor runtime and its companion firewall release.
Changes:
- Adds scoped KVM access and verified runtime-bundle provisioning.
- Emits privileged AWF invocation, runtime sizing, timeout, and topology configuration.
- Updates tests, schema, and runtime documentation.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/nodejs.go |
Adds KVM setup for Node.js engines. |
pkg/workflow/engine_firewall_support.go |
Uses privileged firewall-log parsing. |
pkg/workflow/copilot_engine_installation.go |
Installs AWF system-wide for Cloud Hypervisor. |
pkg/workflow/codex_engine.go |
Adds KVM setup for Codex. |
pkg/workflow/cloud_hypervisor_test.go |
Expands runtime compilation tests. |
pkg/workflow/cloud_hypervisor_install.go |
Generates the KVM access step. |
pkg/workflow/awf_config.go |
Adds timeout and topology configuration. |
pkg/workflow/awf_command_builder.go |
Adds privileged invocation and runtime flags. |
pkg/parser/schemas/main_workflow_schema.json |
Documents runtime behavior in the schema. |
pkg/constants/constants.go |
Defines command and sizing defaults. |
docs/src/content/docs/reference/glossary.md |
Updates the runtime glossary. |
docs/src/content/docs/reference/frontmatter-full.md |
Refreshes generated frontmatter documentation. |
docs/src/content/docs/reference/agent-runtimes.md |
Documents runtime setup and isolation. |
docs/src/content/docs/introduction/architecture.mdx |
Updates the architecture matrix. |
docs/public/editor/autocomplete-data.json |
Refreshes editor metadata. |
actions/setup/sh/cloud_hypervisor_setup_bundle.sh |
Verifies and exports the runtime bundle. |
actions/setup/sh/cloud_hypervisor_kvm_access.sh |
Grants runner-scoped KVM access. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 17/17 changed files
- Comments generated: 3
- Review effort level: Balanced
|
@copilot Please review the latest Cloud Hypervisor runtime branch state, refresh the branch if needed, and run the Outstanding review items (newest first):
Failed checks from the compact candidate set:
Branch update could not be requested automatically in this run because the local
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Added compile-time validation rejecting sandbox.agent.runtime: cloud-hypervisor combined with gh-proxy/integrity-reactions, legacy-security/allow-host-ports, and enclaves, with tests and doc updates (038b38e follow-up commit). All three copilot-pull-request-reviewer threads on this PR are addressed by that change. |
|
@copilot Please resolve the remaining unresolved review threads, refresh the branch if needed, and run the Outstanding review items (newest first):
Failed checks from the compact candidate set:
Branch update was requested automatically for this run.
|
All three referenced threads (r3779408217, r3779408210, r3779408192) are my own replies on the already-resolved threads from commit 2d7eab7 — they're marked resolved in the PR's review state, not new unresolved feedback. Local build and the focused Cloud Hypervisor tests pass on the current HEAD; no further changes needed. |
|
Caution agentic threat detected DetailsPotential security threats were detected in the agent output. Review the workflow run logs for details. @copilot Please resolve the remaining unresolved review threads, refresh the branch if needed, and run the Outstanding review items (newest first):
Failed checks from the compact candidate set:
Branch update could not be requested automatically in this run because the safe update path was unavailable in the current environment.
|
The three listed threads (r3779408217, r3779408210, r3779408192) are already resolved by commit 2d7eab7, which added the compile-time validations in |
|
@copilot Please verify the already-addressed review replies are reflected in the current PR thread state, refresh the branch if needed, and run the Outstanding review items (newest first):
Failed checks from the compact candidate set:
Branch update was not requested automatically in this run because the PR already has recent completed follow-up activity.
|
Confirmed via the GitHub API: all three threads (r3779408192, r3779408210, r3779408217) show |
Summary
Completes the Cloud Hypervisor (preview) microVM runtime for AWF-sandboxed agents. Adds a
virtiofsdbinary to the release bundle and its checksum/manifest verification, grants the runner scoped/dev/kvmaccess via a dedicated setup step, switches the AWF invocation to a privilegedsudo --preserve-env awfcommand instead of legacy-Esudo, sizes the guest VM (2 vCPUs, 4096 MiB), attaches the MCP gateway to the isolated network topology (while explicitly excluding the CLI proxy sidecar), and adds compile-time validation that rejects unsupported feature combinations (gh-proxymode,legacy-security,allow-host-ports,enclaves) whensandbox.agent.runtime: cloud-hypervisoris set.Change Classification
Key Changes
actions/setup/sh/cloud_hypervisor_kvm_access.sh/dev/kvm, restricted to GitHub-hosted Ubuntu x86_64actions/setup/sh/cloud_hypervisor_setup_bundle.shvirtiofsdpath/sha256 resolution, colocation check, and manifest schema/digest cross-validationpkg/workflow/awf_command_builder.go--cloud-hypervisor-vcpus/--cloud-hypervisor-memory-mibargs,--cloud-hypervisor-virtiofsd-sha256, and switches command prefix tosudo --preserve-env awffor this runtimepkg/workflow/awf_config.gopkg/workflow/cloud_hypervisor_install.gogenerateCloudHypervisorKVMAccessSteppkg/workflow/codex_engine.go,pkg/workflow/nodejs.gopkg/workflow/copilot_engine_installation.go,pkg/workflow/engine_firewall_support.go--rootless/install-path decisionspkg/workflow/sandbox_validation.gogh-proxy,legacy-security,allow-host-ports, andenclaveswith cloud-hypervisorpkg/constants/constants.goAWFCloudHypervisorCommand,DefaultCloudHypervisorVCPUs,DefaultCloudHypervisorMemoryMiBpkg/parser/schemas/main_workflow_schema.json,docs/public/editor/autocomplete-data.json,docs/src/content/docs/reference/*,docs/src/content/docs/introduction/architecture.mdxambient-folders,enclaves, Vertex AI WIF fields, cache/repo-memoryvalidationhooks, OTLP workload-identity)pkg/workflow/cloud_hypervisor_test.goImpact Assessment
sandbox.agent.runtime: cloud-hypervisornow install a KVM ACL step, downloadvirtiofsd, and invoke AWF withsudo --preserve-envand explicit vCPU/memory flags — regenerated lock files for such workflows will change.tools.github.mode: gh-proxy,sandbox.agent.legacy-security: enable,sandbox.agent.allow-host-ports, orenclaveswill now failgh aw compilewith a descriptive validation error.awmg-mcpg) is now attached to the isolated network topology for cloud-hypervisor guests; the CLI proxy sidecar remains unattached.gh aw compileschema validation for several unrelated new frontmatter fields introduced alongside this change.Commits