Fail closed on unrecognized autonomy/write-scope values when seeding compiled policy

[Copilot]

PolicyCompiler.Compile seeded the accumulator with deepCopyPolicy(rule.Set) from the first matching rule, bypassing the rank tables entirely. An invalid enum string (e.g. "boundeed") was carried into the compiled ExecutionPolicy untouched and, since unmapped values rank 0, could never be tightened by later rules — a fail-open path that would matter once Authorizer.AuthorizeTool wiring lands.

rule := PolicyRule{Set: ExecutionPolicy{Autonomy: "boundeed", WriteScope: "any_branchh"}}
// before: policy.Autonomy == "boundeed", and a later "bounded" rule couldn't tighten it
// after:  policy.Autonomy == "propose_only", policy.WriteScope == "none"

Changes

• pkg/intent/policy.go — new sanitizeSeedPolicy validates Autonomy/WriteScope against autonomyRank/writeScopeRank when seeding, substituting the safest default for unrecognized values and logging the substitution. Empty strings continue to mean "unspecified" so mergePolicy's existing semantics are unchanged. The first-match log line now reports the sanitized values.
• specs/intent-attribution-compliance/explicit-intent-wins.yaml — the fixture used bounded_autonomous/limited, neither of which appears in the spec's enum list (specs/intent-attribution-agent-governance.md:435-436); corrected to bounded/feature_branch. This fixture was itself an instance of the bug being fixed.
• pkg/intent/intent_formal_test.go — TestFormal_SeedRuleEnumValidation covers typo'd seeds, valid values preserved, unset values left unspecified, and that a sanitized seed cannot be relaxed by a later permissive rule.

The merge path already failed closed (rank 0 never wins), so no change was needed there.

• Fixes [deep-report] PolicyCompiler.Compile does not validate Autonomy/WriteScope enum values on the seeding rule #52516

[Copilot]

Pull request overview

Closes the policy-seeding fail-open gap by sanitizing invalid autonomy and write-scope values.

Changes:

• Replaces invalid seeded enum values with fail-closed defaults.
• Corrects compliance fixture enum values.
• Adds regression coverage for valid, invalid, unset, and merged policies.

Show a summary per file

File	Description
pkg/intent/policy.go	Sanitizes first-match policy values.
pkg/intent/intent_formal_test.go	Tests seed enum validation.
specs/intent-attribution-compliance/explicit-intent-wins.yaml	Uses specification-compliant enums.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced