docs: clarify safe-output tool names, add incident dedup patterns, expand visual-regression guidance#40127
Closed
Copilot wants to merge 5 commits into
Closed
docs: clarify safe-output tool names, add incident dedup patterns, expand visual-regression guidance#40127Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
…pand visual-regression guidance Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…p guidance Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update findings from agent persona exploration
docs: clarify safe-output tool names, add incident dedup patterns, expand visual-regression guidance
Jun 18, 2026
pelikhan
reviewed
Jun 19, 2026
| max-uploads: 5 | ||
| retention-days: 14 # keep diffs for 2 weeks (range: 1-90) | ||
| allowed-paths: | ||
| - "/tmp/visual-regression/**" |
Collaborator
There was a problem hiding this comment.
@copilot allowed paths are relative to the repo workspace root
Contributor
Author
There was a problem hiding this comment.
Fixed in 9a8706e — changed allowed-paths to visual-regression-diffs/** (workspace-relative) in both the example workflow and the Artifact Retention section, and updated the prompt to instruct the agent to copy diffs there before uploading.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
|
@copilot review changes and unbloat, keep high importance information |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in the latest commit. Trimmed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent persona testing surfaced three gaps in the agentic workflow reference docs: ambiguous safe-output tool/import naming, missing duplicate-detection guidance for incident workflows, and thin lifecycle guidance for visual regression baselines.
safe-outputs-content.md— naming convention + comment-vs-issue decision tableadd-comment:→add_comment,create-issue:→create_issue. Customjobs:/actions:entries follow the same rule.add-comment; incident/report needing follow-up →create-issue; rolling status →add-comment+hide-older-comments: true; recurring digest →group-by-day: true).create-agentic-workflow.md— incident workflow duplicate detection (new §2a)Three concrete patterns for
deployment_status/workflow_runtriggered incident workflows:Also documents the prompt-side pattern (agent queries for open issues before calling
create_issue) and guidance on when to combine approaches for defense-in-depth on high-volume triggers.visual-regression.md— baseline storage, update workflow, artifact retentionworkflow_dispatchworkflow for updating baselines after intentional UI changes.upload-artifact(run-scoped,retention-days: 14) for downloadable diff archives;upload-assetfor stable embeddable URLs when diff images need to appear inline in comments.upload-artifactfor diff screenshots alongsideadd-comment.