fix(daily-spdd-spec-planner): add sed to bash allowlist to prevent tool denial threshold#40124
Closed
Copilot wants to merge 2 commits into
Closed
fix(daily-spdd-spec-planner): add sed to bash allowlist to prevent tool denial threshold#40124Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ol denial threshold Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tool denial limit in daily SPDD Spec Planner
fix(daily-spdd-spec-planner): add sed to bash allowlist to prevent tool denial threshold
Jun 18, 2026
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change is a minimal, consistent allowlist update (already used in other workflows) and the compiled lockfile reflects the intended permission.
Note: this review does not count toward required approvals for merging.
Pull request overview
This PR updates the Daily SPDD Spec Planner workflow’s shell allowlist to permit sed -n, preventing Copilot SDK tool-denial accumulation when large cat outputs are redirected to /tmp/copilot-tool-output-*.txt and then paginated via sed.
Changes:
- Added
"sed -n"to the workflow’stools.bashallowlist. - Recompiled the workflow so the generated
.lock.ymlincludes--allow-tool shell(sed -n).
File summaries
| File | Description |
|---|---|
| .github/workflows/daily-spdd-spec-planner.md | Adds sed -n to the bash allowlist to support pagination of large tool outputs. |
| .github/workflows/daily-spdd-spec-planner.lock.yml | Regenerates the compiled workflow to include the corresponding --allow-tool shell(sed -n) entries. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Daily SPDD Spec Planner was hitting the 5/5 tool denial guardrail, causing early session termination. Two independent denial sources compounded to reach the threshold:
globtool callsread(/workspace)(not in--allow-tool); three parallel glob calls at turn 1 consumed 3 of the 5 slotscat specs/*.mdoutput exceeds the Copilot SDK's inline limit, it's saved to/tmp/copilot-tool-output-*.txt; the agent then usessed -nto paginate it, butsedwas absent from the bash allowlistChange
Added
"sed -n"to thebash:allowlist indaily-spdd-spec-planner.mdand recompiled:This emits
--allow-tool shell(sed -n)in the compiled workflow, allowing the agent to paginate large tool outputs. Theglobdenials remain (they are pre-existing and test-documented) but total denials drop from 5 → 3, safely under the threshold.