[WIP] Fix failing GitHub Actions job for integration add with dispatch-workflow#40109
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey One thing to address before this is ready for review:
If you'd like a hand, here's a prompt you can run: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the failing CI job “Integration Add with dispatch-workflow Dependencies” by pinning the remote workflow used by TestAddWorkflowWithDispatchWorkflowDependency to a revision before private: true was introduced, so gh aw add can still fetch the workflow and its dispatch-workflow dependency during integration testing.
Changes:
- Replace the
@mainworkflow reference with a pinned revision for.github/workflows/test-dispatcher.mdin the integration test. - Add inline comments explaining why the workflow spec is pinned (to avoid the
private: truechange).
Show a summary per file
| File | Description |
|---|---|
pkg/cli/add_integration_test.go |
Updates the dispatch-workflow add integration test to use a pinned upstream workflow revision instead of @main. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| // Pin to the last public revision (6d18ddf01ec9aaac84f679ebecfcf6d66aa31153) | ||
| // before private: true was added in e8ca23ae1d. | ||
| workflowSpec := "github/gh-aw/.github/workflows/test-dispatcher.md@6d18ddf01ec9aaac84f679ebecfcf6d66aa31153" |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.